Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning
From: Nick Desaulniers
Date: Thu Aug 24 2017 - 12:25:48 EST
bumping for review (resending, had gmail set to html mode)
On Mon, Aug 14, 2017 at 10:36 AM, Nick Desaulniers
<ndesaulniers@xxxxxxxxxx> wrote:
> Minor nit for the commit message that can get fixed up when being merged:
>
> On Fri, Aug 11, 2017 at 11:16 AM, Nick Desaulniers
> <ndesaulniers@xxxxxxxxxx> wrote:
>
>> if (x)
>> return
>> ...
>>
>> rather than:
>>
>> if (!x == 0)
>
> should remove the `!`, ex:
>
> if (x == 0)
>
>> ...
>> else
>> return
>
> --
> Thanks,
> ~Nick Desaulniers
--
Thanks,
~Nick Desaulniers