Re: [PATCH] x86/mm: fix use-after-free of ldt_struct

[Linus Torvalds]

Ingo,

 I'm assuming I get this through the -tip tree, which is where the
original commit 39a0526fb3f7 ("x86/mm: Factor out LDT init from
context init") came from.

                    Linus

On Thu, Aug 24, 2017 at 10:59 AM, Dave Hansen
<dave.hansen@xxxxxxxxxxxxxxx> wrote:
> On 08/24/2017 10:50 AM, Eric Biggers wrote:
>> --- a/arch/x86/include/asm/mmu_context.h
>> +++ b/arch/x86/include/asm/mmu_context.h
>> @@ -148,9 +148,7 @@ static inline int init_new_context(struct task_struct *tsk,
>>               mm->context.execute_only_pkey = -1;
>>       }
>>       #endif
>> -     init_new_context_ldt(tsk, mm);
>> -
>> -     return 0;
>> +     return init_new_context_ldt(tsk, mm);
>>  }
>
> Sheesh.  That was silly.  Thanks for finding and fixing this!  Feel free
> to add my ack on it.