Re: [PATCH net-next] tg3: Be drop monitor friendly
From: Florian Fainelli
Date: Thu Aug 24 2017 - 20:42:51 EST
On 08/24/2017 05:04 PM, Michael Chan wrote:
> On Thu, Aug 24, 2017 at 4:25 PM, Florian Fainelli <f.fainelli@xxxxxxxxx
> <mailto:f.fainelli@xxxxxxxxx>> wrote:
>>
>> tg3_tx() does the normal packet TX completion,
>> tigon3_dma_hwbug_workaround() needs to allocate a new SKB that is
>> suitable for the DMA hardware bug, and finally tg3_free_rings() is doing
>> ring cleanup. Use dev_consume_skb_any() for these 3 locations to be SKB
>> drop monitor friendly.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx
> <mailto:f.fainelli@xxxxxxxxx>>
>
> Florian, the one at the end of tg3_tso_bug() should also be converted to
> dev_consume_skb_any(). tg3_tso_bug() is similar to
> tigon3_dma_hwbug_workaround(). Thanks.
Indeed, thanks, will resubmit.
--
Florian