Re: [PATCH] strparser: initialize all callbacks

[David Miller]

From: Eric Biggers <ebiggers3@xxxxxxxxx>
Date: Thu, 24 Aug 2017 14:38:51 -0700

> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> commit bbb03029a899 ("strparser: Generalize strparser") added more
> function pointers to 'struct strp_callbacks'; however, kcm_attach() was
> not updated to initialize them.  This could cause the ->lock() and/or
> ->unlock() function pointers to be set to garbage values, causing a
> crash in strp_work().
> 
> Fix the bug by moving the callback structs into static memory, so
> unspecified members are zeroed.  Also constify them while we're at it.
> 
> This bug was found by syzkaller, which encountered the following splat:
 ...
> Fixes: bbb03029a899 ("strparser: Generalize strparser")
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

This commit is only in net-next, so that is where I am applying
this patch.

Thanks.