Re: [PATCH] trace-cmd report: Fix hash.key in option -w
From: Steven Rostedt
Date: Fri Aug 25 2017 - 10:22:36 EST
On Fri, 25 Aug 2017 13:47:49 +0800
"Ziqian SUN (Zamir)" <zsun@xxxxxxxxxx> wrote:
> From: "Ziqian SUN (Zamir)" <zsun@xxxxxxxxxx>
>
> In add_wakeup function the hash list is created with hash.key = value.
> This makes add_sched function will never find a match with the key which
> results in trace-cmd report will never show the average latency with the
> following command:
> trace-cmd report -w -F 'sched_switch,sched_wakeup'
> With this patch, the command will show average latency as it used to be
> in v2.4.2 like
>
> Average wakeup latency: 28.460 usecs
> Maximum Latency: 669.268 usecs at timestamp: 16337.629767
> Minimum Latency: 2.153 usecs at timestamp: 16337.533735
>
> RT task timings:
>
> Average wakeup latency: 23.106 usecs
> Maximum Latency: 57.482 usecs at timestamp: 16337.187531
> Minimum Latency: 4.127 usecs at timestamp: 16336.945209
>
> Reported-by: Joe Mario <jmario@xxxxxxxxxx>
> Signed-off-by: Ziqian SUN (Zamir) <zsun@xxxxxxxxxx>
Thanks a lot Ziqian! Added. Will push out soon.
I need to update the stables too.
-- Steve