Re: [PATCH] OF: move extern declarations of entry pointers inside ifdef

From: Steven Rostedt
Date: Fri Aug 25 2017 - 11:25:49 EST


On Fri, 25 Aug 2017 15:20:12 +0000
Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx> wrote:

> On Fri, 2017-08-25 at 11:12 -0400, Steven Rostedt wrote:
> > On Fri, 25 Aug 2017 18:00:26 +0300
> > Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx> wrote:
> >
> > > Move extern declarations of "of_root", "of_chosen", "of_aliases",
> > > "of_stdout" pointers inside "CONFIG_OF" ifdef to be able to get rid
> > > of "CONFIG_OF" ifdef in their usage places.
> > >
> > > Suggested-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> >
> > Thanks!
> > -- Steve
>
> Could you please ACK my patch if it looks good for you?
> Thanks.

I could, but ACKs are usually for the maintainer of the code being
changed. I don't maintain include/linux/of.h

But for what it's worth...

Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve