Re: [PATCH net-next v2 00/14] net: mvpp2: comphy configuration

From: Andrew Lunn
Date: Fri Aug 25 2017 - 11:51:26 EST

Next message: Brendan Jackman: "Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest."
Previous message: Tom Herbert: "Re: [PATCH] strparser: initialize all callbacks"
In reply to: Antoine Tenart: "[PATCH net-next v2 03/14] Documentation/bindings: phy: document the Marvell comphy driver"
Next in thread: Antoine Tenart: "Re: [PATCH net-next v2 00/14] net: mvpp2: comphy configuration"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> - Checked if the carrier_on/off functions were needed. They are.

Hi Antoine

Could you explain the situations they are needed in?

Quite a few drivers do this, so i'm not saying it is wrong. But it
would be nice to understand if we are missing something in phylib.

Andrew

Next message: Brendan Jackman: "Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest."
Previous message: Tom Herbert: "Re: [PATCH] strparser: initialize all callbacks"
In reply to: Antoine Tenart: "[PATCH net-next v2 03/14] Documentation/bindings: phy: document the Marvell comphy driver"
Next in thread: Antoine Tenart: "Re: [PATCH net-next v2 00/14] net: mvpp2: comphy configuration"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]