Re: [patch 12/41] x86/mce: Remove duplicated tracing interrupt code

From: Thomas Gleixner
Date: Fri Aug 25 2017 - 12:13:39 EST


On Fri, 25 Aug 2017, Steven Rostedt wrote:
> On Fri, 25 Aug 2017 12:31:15 +0200
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > trace_deferred_error_apic_entry(DEFERRED_ERROR_VECTOR);
> > - __smp_deferred_error_interrupt();
> > + inc_irq_stat(irq_deferred_error_count);
>
> Here we do the inc_irq_stat() after the tracepoint (same as the
> original).
> > entering_irq();
> > + inc_irq_stat(irq_thermal_count);
> > trace_thermal_apic_entry(THERMAL_APIC_VECTOR);
>
> Here we do the inc_irq_stat() after the tracepoint (swapped from the
> original). Was that intentional?

No. Not that it matters at all, but I can make it consistent everywhere.