Re: [PATCH] tpm_tis: make array cmd_getticks static const to shink object code size

From: Jarkko Sakkinen
Date: Fri Aug 25 2017 - 13:31:31 EST


On Fri, Aug 25, 2017 at 10:52:42AM -0600, Jason Gunthorpe wrote:
> On Fri, Aug 25, 2017 at 05:45:05PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > Don't populate array cmd_getticks on the stack, instead make it static
> > const. Makes the object code smaller by over 160 bytes:
> >
> > Before:
> > text data bss dec hex filename
> > 18813 3152 128 22093 564d drivers/char/tpm/tpm_tis_core.o
> >
> > After:
> > text data bss dec hex filename
> > 18554 3248 128 21930 55aa drivers/char/tpm/tpm_tis_core.o
> >
> > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Reviewed-by: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx>
>
> Jason

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>

/Jarkko