Re: [PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling

From: John Stultz
Date: Fri Aug 25 2017 - 19:16:50 EST


On Thu, Aug 17, 2017 at 12:03 PM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> In the earlier commit dad3f793f20f ("usb: dwc2: Make sure we
> disconnect the gadget state"), I was trying to fix up the
> fact that we somehow weren't disconnecting the gadget state,
> so that when the OTG port was plugged in the second time we
> would get warnings about the state tracking being wrong.
>
> The fix there was somewhat simple, as it just made sure to
> call dwc2_hsotg_disconnect() before we connected things up
> in OTG mode.
>
> But in looking at a different issue I was seeing with UDC
> state handling, I realized that it would be much better
> to call dwc2_hsotg_disconnect when we get the state change
> signal moving to host mode.
>
> Thus, this patch removes the earlier disconnect call I added
> and moves it (and the needed locking) to the host mode
> transition.

Ping? I don't mean to be a bother, but any thoughts on this patchset?

thanks
-john