Re: [PATCH 0/6] perf tools: Minor build fixes

[David Carrillo-Cisneros]

On Mon, Aug 28, 2017 at 7:16 AM, Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
> Em Mon, Aug 28, 2017 at 11:34:21AM +0200, Jiri Olsa escreveu:
>> On Sun, Aug 27, 2017 at 12:54:36AM -0700, David Carrillo-Cisneros wrote:
>> > Collection of minor fixes to compile with LLVM and
>> > non-standard tool names.
>> >
>> > David Carrillo-Cisneros (6):
>> >   tools build tests: Don't hardcode gcc name
>> >   perf tools: Allow external definition of flex and bison binary names
>> >   tools lib: Allow external definition of CC, AR and LD
>> >   perf tools: Robustify detection of clang binary
>> >   perf tools: Remove BUG_ON char[] to bool implicit conversions
>> >   perf tools: Pass full path of FEATURES_DUMP
>>
>> apart from comment for 5/6 I'm ok with this
>>
>> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
>
> Thanks, applied all that Jiri acked, agree with him that BUG should be
> avoided, and also that we should use existing facilities when available,
> and when there aren't, try to replicate as best as we can similar
> facilities existing in the kernel source code.

Thank you for applying them. I sent a new version of the one commented by Jiri.

David

>
> - Arnaldo