Re: [PATCH] perf symbols: Fix plt entry calculation for ARM and AARCH64

[Arnaldo Carvalho de Melo]

Em Tue, Jun 06, 2017 at 10:47:26AM +0900, Namhyung Kim escreveu:
> On Mon, Jun 5, 2017 at 9:34 AM, Li Bin <huawei.libin@xxxxxxxxxx> wrote:
> > On x86, the plt header size is as same as the plt entry size, and
> > can be identified from shdr's sh_entsize of the plt.
> > But we cann't assume that the sh_entsize of the plt shdr is always
> > the plt entry size in all architecture, and the plt header size may
> > be not as same as the plt entry size in some architecure.
> >
> > On ARM, the plt header size is 20 bytes and the plt entry size is 12
> > bytes(don't consider the FOUR_WORD_PLT case)
> > that refer to the binutils implementation.
<SNIP>
> > NOTES:
> > In addition to ARM and AARCH64, other architectures, such as
> > s390/alpha/mips/parisc/poperpc/sh/sparc/xtensa also need to consider
> > this issue.
> >
> > Signed-off-by: Li Bin <huawei.libin@xxxxxxxxxx>
> 
> I don't know other archs, but this change looks ok to me..
> 
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks, and sorry for the delay in processing this one.

- Arnaldo