Re: [PATCH v4 2/3] livepatch: move transition "complete" notice into klp_complete_transition()

From: Josh Poimboeuf
Date: Tue Aug 29 2017 - 11:53:55 EST


On Fri, Aug 25, 2017 at 03:10:01PM -0400, Joe Lawrence wrote:
> klp_complete_transition() performs a bit of housework before a
> transition to KLP_PATCHED or KLP_UNPATCHED is actually completed
> (including post-(un)patch callbacks). To be consistent, move the
> transition "complete" kernel log notice out of
> klp_try_complete_transition() and into klp_complete_transition().
>
> Signed-off-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
> Suggested-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

I think the Signed-off-by should always be the last line. Otherwise:

Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

--
Josh