Re: [v2,2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation

From: Guenter Roeck
Date: Tue Aug 29 2017 - 21:01:34 EST


On Mon, Aug 21, 2017 at 02:41:23PM +0200, Florian Eckert wrote:
> Document the devicetree bindings for the ltq-cputemp
>
> Signed-off-by: Florian Eckert <fe@xxxxxxxxxx>

When you resend, please copy DT maintainers.

> ---
> Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> new file mode 100644
> index 000000000000..991b05cbcb4a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> @@ -0,0 +1,10 @@
> +Lantiq cpu temperatur sensor driver

Nitpick: s/driver//

The file describes the sensor, not the driver.

> +
> +Requires node properties:

Required

> +- "compatible" value :

Just "- compatible:" (without the '"')

> + "lantiq,cputemp"
> +
> +Example:
> + cputemp@0 {
> + compatible = "lantiq,cputemp";
> + };