RE: [PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from aac_convert_sgraw2()

From: Raghava Aditya Renukunta
Date: Tue Aug 29 2017 - 22:11:34 EST




> -----Original Message-----
> From: Nikola Pajkovsky [mailto:npajkovsky@xxxxxxx]
> Sent: Tuesday, August 29, 2017 4:59 AM
> To: dl-esc-Aacraid Linux Driver <aacraid@xxxxxxxxxxxxx>
> Cc: Nikola Pajkovsky <npajkovsky@xxxxxxx>; James E.J. Bottomley
> <jejb@xxxxxxxxxxxxxxxxxx>; Martin K. Petersen
> <martin.petersen@xxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from
> aac_convert_sgraw2()
>
> EXTERNAL EMAIL
>
>
> aac_convert_sgraw2() kmalloc memory and return -1 on error, which
> should be -ENOMEM. However, nobody is checking return value, so with
> this change, -ENOMEM is propagated to upper layer.
>
> Signed-off-by: Nikola Pajkovsky <npajkovsky@xxxxxxx>
> ---
[.....]
Reviewed-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@xxxxxxxxxxxxx>