Re: [PATCH v5 1/2] platform: Add driver for RAVE Supervisory Processor

[Pavel Machek]

On Mon 2017-08-28 09:23:10, Andrey Smirnov wrote:
> On Thu, Aug 24, 2017 at 9:04 AM, Pavel Machek <pavel@xxxxxx> wrote:
> > On Fri 2017-07-28 07:27:03, Andrey Smirnov wrote:
> >> Add a driver for RAVE Supervisory Processor, an MCU implementing
> >> varoius bits of housekeeping functionality (watchdoging, backlight
> >> control, LED control, etc) on RAVE family of products by Zodiac
> >> Inflight Innovations.
> >>
> >> This driver implementes core MFD/serdev device as well as
> >> communication subroutines necessary for commanding the device.
> >
> > This introduces new /sysfs userland interfaces, right? That needs documenting,
> > and some review.
> >
> 
> Correct and yes, good point. I was originally asked to implement all
> of the exposed attributes via sysfs, but, after more discussion, I now
> have green light to move a large chunk of those into debugfs which is
> what I intend to do in v6, I'll also update it to document all of the
> remaining sysfs entries.

Ok, we still would like to have documentation. .. and debugfs is for
debugging, not for production use.

> > For example... bootreason is there on Nokia N900, too. We want to use same interface...
> >
> 
> I tried grepping Documentation/ABI and kernel tree in general for that
> sysfs interface, but wasn't able to find it. If you don't mind, could
> you point me to where it's implemented?

I'm not sure if the implementation is in the mainline, but the
bootloader provides this functionality.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature