Re: [PATCH v2 0/3] livepatch: Introduce force sysfs attribute

From: Miroslav Benes
Date: Wed Aug 30 2017 - 08:56:21 EST


On Wed, 16 Aug 2017, Petr Mladek wrote:

> On Thu 2017-08-10 12:48:12, Miroslav Benes wrote:
> > Currently, livepatch gradually migrate the system from an unpatched to a
> > patched state (or vice versa). Each task drops its TIF_PATCH_PENDING
> > itself when crossing the kernel/user space boundary or it is cleared
> > using the stack checking approach. If there is a task which sleeps on a
> > patched function, the whole transition can get stuck indefinitely.
> >
> > TODO:
> > Now there is a sysfs attribute called "force", which provides two
> > functionalities, "signal" and "force" (previously "unmark"). I haven't
> > managed to come up with better names. Proposals are welcome. On the
> > other hand I do not mind it much.
>
> What about calling the attribute?
>
> transition-speedup
> transition-urge
>
> In each case, I would make it more clear that the attribute
> is related to the transition attribute of each patch.

Umm... I don't like that much and those names would definitely confuse me.
But I'm biased already.

Miroslav