Re: [PATCH v3 03/11] staging: typec: fusb302: Set max supply voltage to 5V

[Guenter Roeck]

On 08/30/2017 02:48 AM, Hans de Goede wrote:
> Anything higher then 5V may damage hardware not capable of it, so
> the only sane default here is 5V. If a board is able to handle a
> higher voltage that should come from board specific data such as
> device-tree and not be hard coded into the fusb302 code.
>
> Cc: "Yueyao (Nathan) Zhu" <yueyao@xxxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>   drivers/staging/typec/fusb302/fusb302.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
> index 03a3809d18f0..6baed06a3c0d 100644
> --- a/drivers/staging/typec/fusb302/fusb302.c
> +++ b/drivers/staging/typec/fusb302/fusb302.c
> @@ -1187,9 +1187,9 @@ static const struct tcpc_config fusb302_tcpc_config = {
>   	.nr_src_pdo = ARRAY_SIZE(src_pdo),
>   	.snk_pdo = snk_pdo,
>   	.nr_snk_pdo = ARRAY_SIZE(snk_pdo),
> -	.max_snk_mv = 9000,
> +	.max_snk_mv = 5000,
>   	.max_snk_ma = 3000,
> -	.max_snk_mw = 27000,
> +	.max_snk_mw = 15000,
>   	.operating_snk_mw = 2500,
>   	.type = TYPEC_PORT_DRP,
>   	.default_role = TYPEC_SINK,