Re: [PATCH] acpi: apei: call into AER handling regardless of severity

[Baicar, Tyler]

On 8/30/2017 11:14 AM, Borislav Petkov wrote:
> On Wed, Aug 30, 2017 at 09:42:08AM -0600, Baicar, Tyler wrote:
> > I think with my two patches we will have the desired functionality:
> >
> > GHES_SEV_CORRECTABLE -> AER_CORRECTABLE -> Print AER info, but do not call
> > do_recovery
> >
> > GHES_SEV_RECOVERABLE -> AER_NONFATAL -> Print AER info and do_recovery
> >
> > GHES_RECOVERABLE and CPER_SEC_RESET -> AER_FATAL -> Print AER info and
> > do_recover
> Right, so I'd like to you create a separate function ghes_do_proc_aer()
> or ghes_handle_aer() or so and carve out all the code inside #ifdef
> CONFIG_ACPI_APEI_PCIEAER into it, add your two changes to the patch and
> slap a big fat comment above the new function explaining *why* we're
> doing what we're doing and how we're mapping all the severities to AER
> severity in order to do recovery and/or only to print the error.
>
> So that it is known and people can see in the future why we're doing
> this and what the logic has been and what kind of policy we're chasing
> and so on and so on...
>
> Ok?
>
> Thanks.
Yes, I can do that.

Thanks,
Tyler

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.