Re: [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports

From: David Miller
Date: Thu Aug 31 2017 - 17:38:35 EST


From: Lipeng <lipeng321@xxxxxxxxxx>
Date: Thu, 31 Aug 2017 21:39:08 +0800

> Config the self_define vlan_type as TPID(0x8100) for vlan identification.
> When normal port initialize vlan configure, set default vlan id as 0.
>
> Signed-off-by: Mingguang Qu <qumingguang@xxxxxxxxxx>
> Signed-off-by: Lipeng <lipeng321@xxxxxxxxxx>

No, that's not what this patch is doing.

> @@ -3308,6 +3308,7 @@ static int hclge_add_mac_vlan_tbl(struct hclge_vport *vport,
> mc_desc[1].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT);
> hclge_cmd_reuse_desc(&mc_desc[2], false);
> mc_desc[2].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_NEXT);
> +
> memcpy(mc_desc[0].data, req,
> sizeof(struct hclge_mac_vlan_tbl_entry));
> ret = hclge_cmd_send(&hdev->hw, mc_desc, 3);

All it does is add an empty line.