RE: [PATCH 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

From: Yoshihiro Shimoda
Date: Thu Aug 31 2017 - 22:43:42 EST


Hello,

> -----Original Message-----
> From: Sergei Shtylyov
> Sent: Thursday, August 31, 2017 6:41 PM
>
> Hello!
>
> On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote:
>
> > The previous code assumed a channel has otg capability if a channel
> > has interrupt property. But, it is not good because:
> > - Battery charging feature also needs interrupt property.
> > - Some R-Car Gen3 SoCs (e.g. R-Car D3) doesn't have OTG capability.
>
> Don't.

Thank you for the point. I will revise it.

Best regards,
Yoshihiro Shimoda

> > So, this patch checks whether usb 2.0 host node has dr_mode property or
> > not. If it has 'dr_mode = "otg";', this driver enables otg capability.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> [...]
>
> MBR, Sergei