Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()

From: kbuild test robot
Date: Fri Sep 01 2017 - 05:12:04 EST

Hi harsha,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.13-rc7 next-20170831]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/harsha/Staging-android-ion-ion-c-Using-WARN_ON-rather-than-BUG/20170901-160600
config: s390-allmodconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=s390

All errors (new ones prefixed by >>):

In file included from include/linux/bug.h:4:0,
from include/linux/mmdebug.h:4,
from arch/s390/include/asm/cmpxchg.h:10,
from arch/s390/include/asm/atomic.h:15,
from include/linux/atomic.h:4,
from include/linux/debug_locks.h:5,
from include/linux/lockdep.h:25,
from include/linux/spinlock_types.h:18,
from include/linux/mutex.h:15,
from include/linux/kernfs.h:13,
from include/linux/sysfs.h:15,
from include/linux/kobject.h:21,
from include/linux/device.h:17,
from drivers/staging/android/ion/ion.c:18:
drivers/staging/android/ion/ion.c: In function 'ion_buffer_add':
>> arch/s390/include/asm/bug.h:54:26: error: expected expression before ')' token
int __ret_warn_on = !!(x); \
^
drivers/staging/android/ion/ion.c:69:4: note: in expansion of macro 'WARN_ON'
WARN_ON();
^~~~~~~
--
In file included from include/linux/bug.h:4:0,
from include/linux/mmdebug.h:4,
from arch/s390/include/asm/cmpxchg.h:10,
from arch/s390/include/asm/atomic.h:15,
from include/linux/atomic.h:4,
from include/linux/debug_locks.h:5,
from include/linux/lockdep.h:25,
from include/linux/spinlock_types.h:18,
from include/linux/mutex.h:15,
from include/linux/kernfs.h:13,
from include/linux/sysfs.h:15,
from include/linux/kobject.h:21,
from include/linux/device.h:17,
from drivers/staging//android/ion/ion.c:18:
drivers/staging//android/ion/ion.c: In function 'ion_buffer_add':
>> arch/s390/include/asm/bug.h:54:26: error: expected expression before ')' token
int __ret_warn_on = !!(x); \
^
drivers/staging//android/ion/ion.c:69:4: note: in expansion of macro 'WARN_ON'
WARN_ON();
^~~~~~~

vim +54 arch/s390/include/asm/bug.h

a9df8e32 arch/s390/include/asm/bug.h Heiko Carstens 2010-01-13 52
c0007f1a include/asm-s390/bug.h Heiko Carstens 2007-04-27 53 #define WARN_ON(x) ({ \
fd0cbdd3 include/asm-s390/bug.h Heiko Carstens 2007-08-02 @54 int __ret_warn_on = !!(x); \
c0007f1a include/asm-s390/bug.h Heiko Carstens 2007-04-27 55 if (__builtin_constant_p(__ret_warn_on)) { \
c0007f1a include/asm-s390/bug.h Heiko Carstens 2007-04-27 56 if (__ret_warn_on) \
b2be0527 arch/s390/include/asm/bug.h Ben Hutchings 2010-04-03 57 __WARN(); \
c0007f1a include/asm-s390/bug.h Heiko Carstens 2007-04-27 58 } else { \
c0007f1a include/asm-s390/bug.h Heiko Carstens 2007-04-27 59 if (unlikely(__ret_warn_on)) \
b2be0527 arch/s390/include/asm/bug.h Ben Hutchings 2010-04-03 60 __WARN(); \
c0007f1a include/asm-s390/bug.h Heiko Carstens 2007-04-27 61 } \
c0007f1a include/asm-s390/bug.h Heiko Carstens 2007-04-27 62 unlikely(__ret_warn_on); \
c0007f1a include/asm-s390/bug.h Heiko Carstens 2007-04-27 63 })
c0007f1a include/asm-s390/bug.h Heiko Carstens 2007-04-27 64

:::::: The code at line 54 was first introduced by commit
:::::: fd0cbdd378258fdf44eac5ea091256a4a665315b Fix WARN_ON() on bitfield ops for all other archs

:::::: TO: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip