Re: [PATCH 01/16] ashmem: switch to ->read_iter

From: Christoph Hellwig
Date: Fri Sep 01 2017 - 06:20:41 EST


On Wed, Aug 30, 2017 at 04:28:55PM +0100, Al Viro wrote:
> On Wed, Aug 30, 2017 at 04:59:52PM +0200, Christoph Hellwig wrote:
> > And use the proper VFS helper for using the backing file.
>
> Actually, I wonder if that update of ->f_pos of the underlying file is
> correct. That's unrelated to this patch, but might be worth sorting
> out while we are at it.

Sure, I'll add that. If ashmem_mutex wasn't a global lock we could
just as easily keep it locked, but I'll leave that to the android
folks.