Re: [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read

From: Christoph Hellwig
Date: Fri Sep 01 2017 - 06:41:48 EST


On Wed, Aug 30, 2017 at 04:41:28PM +0100, Al Viro wrote:
> On Wed, Aug 30, 2017 at 04:59:59PM +0200, Christoph Hellwig wrote:
> > - fpos = vma->vm_pgoff;
> > - fpos <<= PAGE_SHIFT;
>
> > + loff_t fpos = vma->vm_pgoff << PAGE_SHIFT;
>
> Umm... Are you sure it's OK on 32bit hosts?

It's not. Fixed.