Re: [PATCH 2/2] iommu/omap: Add support to program multiple iommus

[Suman Anna]

On 09/01/2017 11:33 AM, Joerg Roedel wrote:
> Hi Suman,
> On Fri, Sep 01, 2017 at 11:21:45AM -0500, Suman Anna wrote:
>> It's primarily a question of whether each iommu platform device need to
>> be represented as a unique iommu_device or not. If you still think that
>> both these need to be presented to iommu core as one device, I would
>> have to add some glue logic in probe to tie the two devices together.
> 
> I think that you should only call iommu_device_register and friends for
> the mmu-device you link the other devices against in .add_device.
> Otherwise people will see two mmus in sysfs, one of them with no devices
> behind it. That is inconsistent with the rest of the patch-set, which
> basically handles bots mmus as one. But changing that should be easy, I
> think.

Thanks for the feedback and suggestions, let me look at adding that logic.

regards
Suman