Re: [PATCH v2 2/2] ARM: dts: rockchip: Add rk3288 vyasa board

[Heiko Stuebner]

Am Freitag, 1. September 2017, 22:36:08 CEST schrieb Jagan Teki:
> On Fri, Sep 1, 2017 at 2:34 AM, Rob Herring <robh@xxxxxxxxxx> wrote:
> > On Sat, Aug 26, 2017 at 03:39:24PM +0530, Jagan Teki wrote:
> >> From: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> >>
> >> This patch adds initial support for rk3288 based
> >> Vyasa board, which is made by Amarula Solutions.
> >>
> >> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> >> ---
> >> Changes for v2:
> >> - Added entry in Documentation/devicetree/bindings/arm/rockchip.txt
> >>
> >>  Documentation/devicetree/bindings/arm/rockchip.txt |   4 +
> >>  arch/arm/boot/dts/Makefile                         |   3 +-
> >>  arch/arm/boot/dts/rk3288-vyasa.dts                 | 312 +++++++++++++++++++++
> >>  3 files changed, 318 insertions(+), 1 deletion(-)
> >>  create mode 100644 arch/arm/boot/dts/rk3288-vyasa.dts
> >
> > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> >
> > I assume the regulator node names are consistent with other platforms,
> > but at some point please fix them to be lowercase and not use '_'. IOW,
> > build the dtbs with "W=2" and fix the warnings.
> 
> Out-off these [1], only /i2c@ff650000 and  /memory are related to this
> dts and these are consistent across rk3288 dts node name, so there is
> nothing that I can fix here. If not please let me know if you find
> any.

And the regulator node-names are actually part of the rk808 binding,
so should also stay that way.


Heiko