Re: [PATCH] qlcnic: remove redundant zero check on retries counter

From: David Miller
Date: Fri Sep 01 2017 - 13:34:13 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Fri, 1 Sep 2017 14:44:31 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> At the end of the do while loop the integer counter retries will
> always be zero and so the subsequent check to see if it is zero
> is always true and therefore redundant. Remove the redundant check
> and always return -EIO on this return path. Also unbreak the literal
> string in dev_err message to clean up a checkpatch warning.
>
> Detected by CoverityScan, CID#744279 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied to net-next, thanks.