RE: [PATCH][staging-next] staging: unisys: visorbus: make two functions static

From: Kershner, David A
Date: Fri Sep 01 2017 - 17:56:13 EST


> -----Original Message-----
> From: Colin King [mailto:colin.king@xxxxxxxxxxxxx]
> Sent: Friday, September 1, 2017 6:08 AM
> To: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Sell, Timothy C
> <Timothy.Sell@xxxxxxxxxx>; Binder, David Anthony
> <David.Binder@xxxxxxxxxx>; Wadgaonkar, Sameer Laxmikant
> <Sameer.Wadgaonkar@xxxxxxxxxx>; Charles Daniels
> <cdaniels@xxxxxxxxxxxx>; Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx>; *S-Par-Maintainer
> <SParMaintainer@xxxxxxxxxx>; devel@xxxxxxxxxxxxxxxxxxxx
> Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH][staging-next] staging: unisys: visorbus: make two functions
> static
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The functions sig_queue_offset and sig_data_offset are local to
> the source and do not need to be in global scope, so make them
> static.
>
> Cleans up sparse warnings:
> symbol 'sig_queue_offset' was not declared. Should it be static?
> symbol 'sig_data_offset' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Acked-by: David Kershner <david.kershner@xxxxxxxxxx>

> ---
> drivers/staging/unisys/visorbus/visorchannel.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

Attachment: smime.p7s
Description: S/MIME cryptographic signature