Re: [RFC PATCH 02/11] refcount: Implement inc/decrement-and-return functions
From: Peter Zijlstra
Date: Fri Sep 01 2017 - 18:03:54 EST
On Fri, Sep 01, 2017 at 11:50:03PM +0200, Peter Zijlstra wrote:
> > Did you read the other other part of the description?
> >
> > Further, both functions can be used to accurately trace the refcount
> > (refcount_inc() followed by refcount_read() can't be considered
> > accurate).
>
> I must admit to having overlooked that. But can we treat the two issues
> separately? They are quite distinct.
So for tracing purposes inc_return/dec_return don't cover the full set.
In particular: inc_not_zero, dec_not_one and dec_and_*lock are not
covered.
dec_if_one I suppose we only care about the success case, in which case
we knew it was one by inference.