Re: [PATCH 05/10] dmaengine: sun6i: Move number of pchans/vchans/request to device struct

From: Maxime Ripard
Date: Mon Sep 04 2017 - 03:44:13 EST


On Mon, Sep 04, 2017 at 12:40:56AM +0200, Stefan Brüns wrote:
> Preparatory patch: If the same compatible is used for different SoCs which
> have a common register layout, but different number of channels, the
> channel count can no longer be stored in the config. Store it in the
> device structure instead.
>
> Signed-off-by: Stefan Brüns <stefan.bruens@xxxxxxxxxxxxxx>

As stated already, we already are going to have a different
compatible, and this is not something that will change from one
instance to the other. Having code is therefore:
A) Making the code more complex
B) For no particular reason.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature