Re: [PATCH 2/2] tracing: Add support for critical section events

From: Peter Zijlstra
Date: Mon Sep 04 2017 - 03:56:26 EST


On Sun, Sep 03, 2017 at 01:50:51AM -0700, Joel Fernandes wrote:
> Critical section trace events can be used for tracing the start and
> end of a critical section which can be used by a trace viewer like
> systrace to graphically view the start and end of a critical section and
> correlate them with latencies and scheduling issues.
>
> Reason for starting critical section:
> Either preemption or interrupts were turned off.
> Reason for ending critical section:
> Both preemption and interrupts are now turned back on.

Please don't use the name critical section for this. Also IRQ and
preempt already have a gazillion trace hooks, why do we need more?