Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop

[Mark Brown]

On Mon, Sep 04, 2017 at 12:03:21PM +0200, Arnaud Pouliquen wrote:

> > +static const struct snd_soc_dai_ops dmic_dai_ops = {
> > +	.trigger	= dmic_daiops_trigger,
> > +};

> should it be handle by trigger or DAPM?

DAPM is a bit better, yes.  I don't think it matters *overly* much in
this case where there's nothing else going on with the device, though
bypass use cases would need it.  OTOH it could mess up the timing.  I
was on the edge with this one but I decided that if it ends up making
a problem the binding is fine and the code can be sorted later.

Attachment: signature.asc
Description: PGP signature