Re: [PATCH v2 2/2] ARM: dts: sun8i: h3: Improved Wifi bindings on Bananapi M2 Plus

[Philipp Rossak]

Hi Maxime

Am 04.09.2017 um 10:05 schrieb Maxime Ripard:
> Hi Philipp,
>
> On Fri, Sep 01, 2017 at 06:30:01PM +0200, Philipp Rossak wrote:
> > From: Philipp Rossak <embed3d@xxxxxxxxx>
> >
> > * vqmmc is in this case not needed
> > * no need for pincontrol nodes when the pin is set to a GPIO
> >
> > Signed-off-by: Philipp Rossak <embed3d@xxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 7 -------
> >   1 file changed, 7 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
> > index d756ff8..f7e5d8a 100644
> > --- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
> > +++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
> > @@ -98,7 +98,6 @@
> >   	wifi_pwrseq: wifi_pwrseq {
> >   		compatible = "mmc-pwrseq-simple";
> >   		pinctrl-names = "default";
> > -		pinctrl-0 = <&wifi_en_bpi_m2p>;
> >   		reset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */
> >   	};
> >   };
> > @@ -153,7 +152,6 @@
> >   	pinctrl-names = "default";
> >   	pinctrl-0 = <&mmc1_pins_a>;
> >   	vmmc-supply = <&reg_vcc3v3>;
> > -	vqmmc-supply = <&reg_vcc3v3>;
>
> So we actually need this one.
>
> >   	mmc-pwrseq = <&wifi_pwrseq>;
> >   	bus-width = <4>;
> >   	non-removable;
> > @@ -200,11 +198,6 @@
> >   		pins = "PL3";
> >   		function = "gpio_in";
> >   	};
> > -
> > -	wifi_en_bpi_m2p: wifi_en_pin {
> > -		pins = "PL7";
> > -		function = "gpio_out";
> > -	};
>
> And there's also other GPIO pins here, I'd prefer if you could tackle
> them all at once.
>
> Thanks!
> Maxime
Thanks for the feedback!
I will fix that with a new single Patch in the next Days.

Philipp