Re: [PATCH 07/11] extcon: intel-int3496: Add support for controlling the USB-role mux

[Hans de Goede]

Hi,

On 02-09-17 12:39, Andy Shevchenko wrote:
> On Sat, Sep 2, 2017 at 12:48 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > Cherry Trail SoCs have a built-in USB-role mux for switching between
> > the host and device controllers, rather then using an external mux
> > controller by a GPIO.
> >
> > There is a driver using the mux-subsys to control this mux, this
> > commit adds support to the intel-int3496 driver to get a mux_controller
> > handle for the mux and set the mux through the mux-subsys rather then
> > through a GPIO.
>
> >          tristate "Intel INT3496 ACPI device extcon driver"
> >          depends on GPIOLIB && ACPI && (X86 || COMPILE_TEST)
> > +       select MULTIPLEXER
>
> > +#include <asm/cpu_device_id.h>
> > +#include <asm/intel-family.h>
>
> I think it is going to fail when !X86 && COMPILE_TEST.

Good catch, I've dropped the || COMPILE_TEST for v2

> >   static void int3496_do_usb_id(struct work_struct *work)
> >   {
> >          struct int3496_data *data =
> >                  container_of(work, struct int3496_data, work.work);
> > -       int id = gpiod_get_value_cansleep(data->gpio_usb_id);
> > +       int ret, id = gpiod_get_value_cansleep(data->gpio_usb_id);
>
> Better to keep them on separate lines.

Ok, fixed for v2.

Regards,

Hans