Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

[jeffy]

Hi Heiko,

On 09/05/2017 06:33 AM, Heiko StÃbner wrote:
> Am Donnerstag, 31. August 2017, 01:00:44 CEST schrieb jeffy:
> > On 08/30/2017 09:30 PM, Heiko StÃbner wrote:
> > > > > -		compatible = "realtek,rt5514";
> > > > > +		compatible = "realtek,rt5514", "realtek,rt5514-i2c";
> > >
> > > the rt5514-i2c and -spi compatibles should be documented in the
> > > binding-txt
> > > of the chip, but I haven't found any mention of this.
> > >
> > >
> > > Heiko
> >
> > these compatibles are only used for our snd driver to detect rt5514 i2c
> > driver and rt5514 spi driver, suggested by Matthias at
> > https://patchwork.kernel.org/patch/9904731/
> >
> > should i add it in the rockchip,rk3399-gru-sound.txt or rt5514 binding
> > document?
>
> You're introducing new bindings for the codec, so they should of course
> part of the rt5514 binding.
ok, will do that.
and it looks like there's no binding for rt5514-spi, will add it too :)
> Heiko