RE: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush

From: 박병철/선임연구원/SW Platform(연)AOT팀(byungchul.park@lge.com)
Date: Tue Sep 05 2017 - 03:36:50 EST


> -----Original Message-----
> From: Peter Zijlstra [mailto:peterz@xxxxxxxxxxxxx]
> Sent: Tuesday, September 05, 2017 4:26 PM
> To: Byungchul Park
> Cc: tj@xxxxxxxxxx; johannes.berg@xxxxxxxxx; mingo@xxxxxxxxxx;
> tglx@xxxxxxxxxxxxx; oleg@xxxxxxxxxx; david@xxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; kernel-team@xxxxxxx
> Subject: Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt
> workqueue flush
>
> On Tue, Sep 05, 2017 at 11:29:14AM +0900, Byungchul Park wrote:
>
> > Also, lock_map_acquire() in process_one_work() is too strong for that
> > purpose. lock_map_acquire_might() is enough. Replaced it.
>
> NAK!! traditional annotations are superior to cross-release. They are not
> timing dependent.

You seem to mis-understand this. This also make them timing independent.
I also agree that we need timing independent report in workqueue code.
That's actually why I propose this patch.

I just tried to do it in a right way.