Re: [PATCH] mm: Fix mem_cgroup_oom_disable() call missing

[Kirill A. Shutemov]

On Tue, Sep 05, 2017 at 05:30:39PM +0200, Laurent Dufour wrote:
> Seen while reading the code, in handle_mm_fault(), in the case
> arch_vma_access_permitted() is failing the call to mem_cgroup_oom_disable()
> is not made.
> 
> To fix that, move the call to mem_cgroup_oom_enable() after calling
> arch_vma_access_permitted() as it should not have entered the memcg OOM.
> 
> Fixes: bae473a423f6 ("mm: introduce fault_env")
> Signed-off-by: Laurent Dufour <ldufour@xxxxxxxxxxxxxxxxxx>

Ouch. Sorry for this.

Acked-by: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>

Cc: stable@ is needed too.

It's strange we haven't seen reports of warning from
mem_cgroup_oom_enable().

-- 
 Kirill A. Shutemov