[PATCH] binder: fix an ret value override

From: Todd Kjos
Date: Tue Sep 05 2017 - 13:25:59 EST


From: Xu YiPing <xuyiping@xxxxxxxxxxxxx>

commit 372e3147df70 ("binder: guarantee txn complete / errors delivered
in-order") incorrectly defined a local ret value. This ret value will
be invalid when out of the if block

Signed-off-by: Xu YiPing <xuyiping@xxxxxxxxxxxx>
Signed-off-by: Todd Kjos <tkjos@xxxxxxxxxx>
---
drivers/android/binder.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 96cc28afa383..7ef9e7f05e17 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2326,7 +2326,6 @@ static int binder_translate_handle(struct flat_binder_object *fp,
(u64)node->ptr);
binder_node_unlock(node);
} else {
- int ret;
struct binder_ref_data dest_rdata;

binder_node_unlock(node);
--
2.14.1.581.gf28d330327-goog