Re: [PATCH] string.h: un-fortify memcpy_and_pad

From: Arnd Bergmann
Date: Tue Sep 05 2017 - 15:26:52 EST


On Tue, Sep 5, 2017 at 8:23 PM, Martin Wilck <mwilck@xxxxxxxx> wrote:
> The way I'd implemented the new helper memcpy_and_pad with
> __FORTIFY_INLINE caused compiler warnings for certain kernel
> configurations.
>
> This helper is only used in a single place at this time, and thus
> doesn't benefit much from fortification. So simplify the code
> by dropping fortification support for now.
>
> Fixes: 3c5fa8cd18f8 "string.h: add memcpy_and_pad()"
> Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>

Looks good to me,

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

I've added this to my randconfig testing tree, if you don't hear anything
from me by tomorrow, you can assume that it caused no other failures.

Arnd