Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro
From: Joe Perches
Date: Tue Sep 05 2017 - 16:01:28 EST
On Tue, 2017-09-05 at 21:45 +0200, Thomas Meyer wrote:
> On Tue, Sep 05, 2017 at 11:50:44AM -0700, David Miller wrote:
> > From: Thomas Meyer <thomas@xxxxxxxx>
> > Date: Sun, 03 Sep 2017 14:19:31 +0200
> >
> > > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it
> > > yourself.
> > > Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e
> > > 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\)
> > > /ARRAY_SIZE(\1)/g' and manual check/verification.
> > >
> > > Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
> >
> > This should be submitted to the Intel ethernet driver maintainers.
>
> Hi,
>
> my script checks the output of get_maintainer scripts and only sends to "open
> list" entries.
>
> The intel-wired-lan@xxxxxxxxxxxxxxxx is moderated, so that's why the patch
> wasn't send there.
>
> Strangely the lists for nouveau@xxxxxxxxxxxxxxxxxxxxx and
> intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx appears as open lists in the MAINTAINERS
> file but seems to be also moderated lists... At least I got some reply that my
> message awaits approval. Maybe an update to the MAINTAINERS file is missing
> here?
>
> I may drop above check in my script and send to all mailing lists that
> get_maintainer.pl will return.
There's a difference between moderated and subscriber-only
entries in MAINTAINERS.
get_maintainers will by default list moderated lists and
not show subscriber-only lists unless using the -s switch.