Re: [PATCH] tty: xilinx_uartps: move to arch_initcall for earlier console
From: Michal Simek
Date: Wed Sep 06 2017 - 08:44:07 EST
On 31.8.2017 14:59, Linus Walleij wrote:
> On Thu, Aug 24, 2017 at 11:32 AM, Michal Simek <michal.simek@xxxxxxxxxx> wrote:
>> On 24.8.2017 01:24, Greg KH wrote:
>>> On Wed, Aug 23, 2017 at 04:50:21PM +0530, Shubhrajyoti Datta wrote:
>>>> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
>>>
>>> I can't take patches without any changelog text at all :(
>>
>> ok. I see you have also commented this.
>>
>> Anyway this is kind of old discussion about moving serial drivers to
>> arch_initcall from module_init.
>>
>> There is one patch in the tree.
>>
>> commit 4dd9e742df98f8f600b4302d3adbb087a68237f7
>> Author: Alessandro Rubini <rubini@xxxxxxxxx>
>> AuthorDate: Tue May 5 05:54:13 2009 +0100
>> Commit: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
>> CommitDate: Sun May 31 14:58:11 2009 +0100
>>
>> [ARM] 5505/1: serial amba-pl011: move to arch_initcall for earlier
>> console
>>
>> Signed-off-by: Alessandro Rubini <rubini@xxxxxxxx>"
>> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
>>
>>
>> and then there was one patch (also sent to linux-serial but don't have link)
>> https://patches.linaro.org/patch/14633/
>>
>> where that discussion wasn't finished.
>
> Yeah Alessandro never came back on that.
>
> I *guess* it is to get the console up really early, simply becaus it is
> quite helpful for spotting early boot problems.
ok. It means no concern about the move to arch_initcall.
Shubhrajyoti: Please send v2 with changelog.
Thanks,
Michal