Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc.

[Javier GonzÃlez]

> On 6 Sep 2017, at 17.13, Jens Axboe <axboe@xxxxxxxxx> wrote:
> 
> On 09/06/2017 09:12 AM, Javier GonzÃlez wrote:
>>> On 6 Sep 2017, at 17.09, Jens Axboe <axboe@xxxxxxxxx> wrote:
>>> 
>>> On 09/06/2017 09:08 AM, Johannes Thumshirn wrote:
>>>> On Wed, Sep 06, 2017 at 05:01:01PM +0200, Javier GonzÃlez wrote:
>>>>> Check for failed mempool allocations and act accordingly.
>>>> 
>>>> Are you sure it is needed? Quoting from mempool_alloc()s Documentation:
>>>> "[...] Note that due to preallocation, this function *never* fails when called
>>>> from process contexts. (it might fail if called from an IRQ context.) [...]"
>>> 
>>> It's not needed, mempool() will never fail if __GFP_WAIT is set in the
>>> mask. The use case here is GFP_KERNEL, which does include __GFP_WAIT.
>> 
>> Thanks for the clarification. Do you just drop the patch, or do you want
>> me to re-send the series?
> 
> No need to resend. I'll pick up the others in a day or two, once people
> have had some time to go over them.
> 

Thanks. And apologies for the delay on the patches...

Javier

Attachment: signature.asc
Description: Message signed with OpenPGP