Re: [PATCH net v2] rds: Fix incorrect statistics counting

From: Santosh Shilimkar
Date: Wed Sep 06 2017 - 12:48:56 EST


On 9/6/2017 9:35 AM, HÃkon Bugge wrote:
In rds_send_xmit() there is logic to batch the sends. However, if
another thread has acquired the lock and has incremented the send_gen,
it is considered a race and we yield. The code incrementing the
s_send_lock_queue_raced statistics counter did not count this event
correctly.

This commit counts the race condition correctly.

Changes from v1:
- Removed check for *someone_on_xmit()*
- Fixed incorrect indentation

Signed-off-by: HÃkon Bugge <haakon.bugge@xxxxxxxxxx>
Reviewed-by: Knut Omang <knut.omang@xxxxxxxxxx>
---

Thanks for the update.
Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxxxxxx>