Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.

[Srishti Sharma]

On Thu, Sep 7, 2017 at 3:02 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> Always compile your patches.
>
>   CC [M]  drivers/staging/ccree/ssi_cipher.o
> drivers/staging/ccree/ssi_cipher.c: In function âssi_blkcipher_completeâ:
> drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable âinflight_counterâ [-Wunused-variable]
>   u32 inflight_counter;
>       ^~~~~~~~~~~~~~~~
>
> You need to delete the declaration as well.
>
> Don't be in a rush to resend patches.  I normally write them then let
> them sit in my outbox overnight and send them in the morning.  The extra
> delay helps me to calm down a bit and focus better.  Even though I've
> sent thousands of patches, it sometimes still stresses me out.  It's
> like you're disagreeing with the original author and the reviewers are
> disagreeing with you and everyone's trying to be nice about it but
> patches are fundamentally points of disagreement and that's stress.
>
> regards,
> dan carpenter
>
 Thanks , I'll be more careful !

 Regards,
 Srishti