Re: [PATCH v3] Input: goodix: Add support for capacitive home button

From: Dmitry Torokhov
Date: Wed Sep 06 2017 - 20:30:15 EST


On Wed, Sep 06, 2017 at 11:03:06AM +0200, Jiri Kosina wrote:
> On Wed, 6 Sep 2017, Bastien Nocera wrote:
>
> > Hey,
> >
> > On Tue, 2017-06-20 at 18:08 +0200, Bastien Nocera wrote:
> > > From: "Sergei A. Trusov" <sergei.a.trusov@xxxxx>
> > >
> > > On some x86 tablets with a Goodix touchscreen, the Windows logo on
> > > the
> > > front is a capacitive home button. Touching this button results in a
> > > touch
> > > with bit 4 of the first byte set, while only the lower 4 bits (0-3)
> > > are
> > > used to indicate the number of touches.
> > >
> > > Report a KEY_LEFTMETA press when this happens.
> > >
> > > Note that the hardware might support more than one button, in which
> > > case the "id" byte of coor_data would identify the button in
> > > question.
> > > This is not implemented as we don't have access to hardware with
> > > multiple buttons.
> > >
> > > Signed-off-by: Sergei A. Trusov <sergei.a.trusov@xxxxx>
> > > Acked-by: Bastien Nocera <hadess@xxxxxxxxxx>
> >
> > Can we please get this merged? I didn't receive any reviews on it, and
> > it's been sitting there for 2 months...
>
> Let's CC Dmitry.

Applied, thank you.

--
Dmitry