Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for sanity check cleanup

[Dou Liyang]

At 09/06/2017 04:03 PM, Baoquan He wrote:
> On 09/06/17 at 01:41pm, Dou Liyang wrote:
> > Hi Baoquan,
> >
> > At 09/06/2017 01:26 PM, Baoquan He wrote:
> > [...]
> > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> > index 4f63afc..9f8479c 100644
> > --- a/arch/x86/kernel/smpboot.c
> > +++ b/arch/x86/kernel/smpboot.c
> > @@ -1260,8 +1260,10 @@ static void __init smp_get_logical_apicid(void)
> >  }
> >
> >  /*
> > - * Prepare for SMP bootup.  The MP table or ACPI has been read
> > - * earlier.  Just do some sanity checking here and enable APIC mode.
> > + * Prepare for SMP bootup.
> > + *
> > + * @max_cpus: configured maximum number of CPUs
> > + * It don't be used, but other arch also have this hook, so keep it.

How about:

@max_cpus: configured maximum number of CPUs
It is a legacy parameter for common interface support

> Yeah, makes sense. Above words can be reconsidered.