Re: [PATCH] drivers/staging/pi433: Fixing coding guidelines

From: Greg KH
Date: Thu Sep 07 2017 - 05:32:23 EST


On Wed, Sep 06, 2017 at 11:12:02AM +0530, Pushkar Jambhlekar wrote:
> Fix brace style of if-else case
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@xxxxxxxxx>
> ---
> drivers/staging/pi433/pi433_if.c | 162 +++++++++++++--------------------------
> 1 file changed, 54 insertions(+), 108 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 93c0168..c070cf3 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -133,19 +133,16 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id)
> {
> struct pi433_device *device = dev_id;
>
> - if (device->irq_state[DIO0] == DIO_PacketSent)
> - {
> + if (device->irq_state[DIO0] == DIO_PacketSent) {

Those extra spaces after "if" really don't need to be there either,
right? Fix that at the same time please.

thanks,

greg k-h