Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

[Gustavo A. R. Silva]

Hi Larry,

On 08/30/2017 11:48 PM, Larry Finger wrote:
> On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote:
> > Refactor code in order to avoid identical code for different branches.
> >
> > This issue was detected with the help of Coccinelle.
> >
> > Addresses-Coverity-ID: 1226788
> > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> > ---
> > This issue was reported by Coverity and it was tested by compilation
> > only.
> > I'm suspicious this may be a copy/paste error. Please, verify.
> >
> >   .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c   | 10
> > ++--------
> >   1 file changed, 2 insertions(+), 8 deletions(-)
>
> This change is not correct. When bt_link_info->sco_exist is true, the
> call should be
>
>                 halbtc8723b1ant_limited_rx(btcoexist,
>                                NORMAL_EXEC, true,
>                                false, 0x5);
>
> NACK
>
> I will push the correct patch.

Great. Good to know.

Thanks
--
Gustavo A. R. Silva