Re: [PATCH 00/12] x86/crypto: Fix RBP usage in several crypto .S files
From: Eric Biggers
Date: Thu Sep 07 2017 - 13:58:12 EST
On Thu, Sep 07, 2017 at 09:15:34AM +0200, Ingo Molnar wrote:
>
> * Eric Biggers <ebiggers3@xxxxxxxxx> wrote:
>
> > Thanks for fixing these! I don't have time to review these in detail, but I ran
> > the crypto self-tests on the affected algorithms, and they all pass. I also
> > benchmarked them before and after; the only noticable performance difference was
> > that sha256-avx2 and sha512-avx2 became a few percent slower. I don't suppose
> > there is a way around that? Otherwise it's probably not a big deal.
>
> Which CPU model did you use for the test?
>
> Thanks,
>
> Ingo
This was on Haswell, "Intel(R) Xeon(R) CPU E5-1650 v3 @ 3.50GHz".
Eric