Re: [PATCH] [RESEND] ata: avoid gcc-7 warning in ata_timing_quantize

From: Tejun Heo
Date: Thu Sep 07 2017 - 16:34:28 EST


On Wed, Sep 06, 2017 at 11:45:34PM +0200, Arnd Bergmann wrote:
> gcc-7 warns about the result of a constant multiplication used as
> a boolean:
>
> drivers/ata/libata-core.c: In function 'ata_timing_quantize':
> drivers/ata/libata-core.c:3164:30: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
>
> This slightly rearranges the macro to simplify the code and avoid
> the warning at the same time.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> Hi Tejun,
>
> I just noticed this patch among others I had previously sent
> but that were not applied. It seems I forgot to reply to your
> Ack after it had become clear that the serious would not
> get merged in one chunk. Please apply this for 4.14.

My bad. I'm sorry. Applied to libata/for-4.14-fixes.

Thanks.

--
tejun